Re: BUG #15238: Sequence owner not updated when owning table isforeign - Mailing list pgsql-bugs

From Peter Eisentraut
Subject Re: BUG #15238: Sequence owner not updated when owning table isforeign
Date
Msg-id e3cf9eb8-add9-f523-b3f8-de657e091a14@2ndquadrant.com
Whole thread Raw
In response to BUG #15238: Sequence owner not updated when owning table is foreign  (PG Bug reporting form <noreply@postgresql.org>)
Responses Re: BUG #15238: Sequence owner not updated when owning table isforeign  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Re: BUG #15238: Sequence owner not updated when owning table isforeign  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Re: BUG #15238: Sequence owner not updated when owning table isforeign  (Christoph Berg <christoph.berg@credativ.de>)
List pgsql-bugs
On 6/12/18 09:21, PG Bug reporting form wrote:
> If a foreign table has a sequence attached (e.g. if the foreign table has a
> "serial" column), and the foreign table owner is updated, the sequence owner
> is not updated, leading to errors on restore:

Yup, it only recurses to sequences for regular tables and materialized
views.  I suggest to remove the relkind check altogether.  See attached
patch.

Can materialized views even have serial columns?  I suspect materialized
views entered this conditional because of the toast table check nearby.

Also, can partitioned tables have serial columns?  Are there more omissions?

So fewer relkind enumerations are probably better.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-bugs by date:

Previous
From: Andrew Gierth
Date:
Subject: Re: BUG #15242: JSON functions not recognizing JSON
Next
From: Alvaro Herrera
Date:
Subject: Re: BUG #15238: Sequence owner not updated when owning table isforeign