Re: Adding locks statistics - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: Adding locks statistics
Date
Msg-id e38089eb-3619-4434-b888-397175c4eaa9@app.fastmail.com
Whole thread Raw
In response to Re: Adding locks statistics  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Adding locks statistics
List pgsql-hackers
On 2026-03-21, Michael Paquier wrote:
> On Thu, Mar 19, 2026 at 12:25:41PM +0000, Bertrand Drouvot wrote:

>> I did not check if there are any other files that could benefit of using
>> locktag.h instead of lock.h but that's something I'll do and open a dedicated
>> if any (once locktag.h is in the tree).
>
> I have checked after that, and did not spot an area (except your patch
> of course).  And applied this part.

I checked this, and found a couple of headers that can benefit from a removal, as shown in the attached patches.

A special case (not modified here) is proc.h. It seems to me that lock.h _could_ be removed from there with some
effort,but the amount of .c files that would benefit seems to me not large enough to justify the number of contortions
needed. Others could disagree though. 

--
Álvaro Herrera
Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: index prefetching
Next
From: Daniel Gustafsson
Date:
Subject: Re: Proposal: Implementing Botan as an alternative TLS backend for PostgreSQL