On 14/8/2024 23:05, Imseih (AWS), Sami wrote:
>> I think the testing discussion should be moved to a different thread.
>> What do you think?
> See v4.
>
> 0001 deals with reporting queryId in exec_execute_message and
> exec_bind_message.
> 0002 deals with reporting queryId after a cache invalidation.
>
> There are no tests as this requires more discussion in a separate thread(?)
At first, these patches look good.
But I have a feeling of some mess here:
queryId should be initialised at the top-level query. At the same time,
the RevalidateCachedQuery routine can change this value in the case of
the query tree re-validation.
You can say that this routine can't be called from a non-top-level query
right now, except SPI. Yes, but what about extensions or future usage?
--
regards, Andrei Lepikhov
