Re: pgsql: Have test_fsync honor -f filename argument. - Mailing list pgsql-committers

"Bruce Momjian" <momjian@svr1.postgresql.org> wrote
> -----------
> Have test_fsync honor -f filename argument.
>

The patch may forget to change the error message (Also, it would be better
to append a '\n' in die() function). Another possible problem of this test
is that it pickups the "/var/tmp". OS may have IO optimization on temporary
directories, which will affect the confidence of the results.

Example:
---
$#./test_fsync -f $HOME/test.out
Simple write timing:
        write                    4.265149
$#./test_fsync -f /var/tmp/test.out
Simple write timing:
        write                    0.018404
$#./test_fsync -f /tmp/test.out
Simple write timing:
        write                    0.018511
---

Regards,
Qingqing