Re: [HACKERS] safer node casting - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] safer node casting
Date
Msg-id dffd9a0f-3a90-23ca-6c7d-81f306ac8729@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] safer node casting  (Andres Freund <andres@anarazel.de>)
Responses Re: [HACKERS] safer node casting  (Jeff Janes <jeff.janes@gmail.com>)
List pgsql-hackers
On 1/26/17 16:15, Andres Freund wrote:
> On 2017-01-25 19:21:40 -0500, Tom Lane wrote:
>> Andres Freund <andres@anarazel.de> writes:
>>> On 2016-12-31 12:08:22 -0500, Peter Eisentraut wrote:
>>>> RestrictInfo *rinfo = castNode(RestrictInfo, lfirst(lc));
>>
>>> Are you planning to add this / update this patch? Because I really would
>>> have liked this a number of times already...  I can update it according
>>> to my suggestions (to avoid multiple eval scenarios) if helpful
>>
>> Yeah, I'd like that in sooner rather than later, too.  But we do need
>> it to be foolproof - no multiple evals.  The first draft had
>> inadequate-parenthesization hazards,
> 
> How about something like the attached? The first patch just contains
> castNode(), the second one a rebased version of Peter's changes (with
> some long lines broken up).

Thanks for finishing that up.  I have committed more uses that I had
lying around partially done.  Looks nice now.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Yugo Nagata
Date:
Subject: Re: [HACKERS] Documentation improvements for partitioning
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] drop support for Python 2.3