On 2/21/26 4:07 PM, jian he wrote:
> V1 is way too complicated.
> IMHO, we can just do
>
> if (node != NULL)
> part_attmap = build_attrmap_by_name(RelationGetDescr(partrel),
> RelationGetDescr(firstResultRel),
> false);
>
> We have now consolidated five uses of build_attrmap_by_name into one.
Hm, why would that be ok? As far as I can tell the current code tries
hard to not build the attmap unless it is actually needed while you
propose to build it almost unconditionally. While the code is less
complicated with your patch it instead has to do more work in some
cases, right?
Andreas
