Re: Underscores in numeric literals - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Underscores in numeric literals
Date
Msg-id de21d0dc-cc09-430d-f74e-1121028632cf@enterprisedb.com
Whole thread Raw
In response to Re: Underscores in numeric literals  (Dean Rasheed <dean.a.rasheed@gmail.com>)
Responses Re: Underscores in numeric literals
List pgsql-hackers
On 23.01.23 21:45, Dean Rasheed wrote:
> On Wed, 4 Jan 2023 at 09:28, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
>>
>> In addition, I think that strip_underscores() could then go away if
>> numeric_in() were made to handle underscores.
>>
>> Essentially then, that would move all responsibility for parsing
>> underscores and non-decimal integers to the datatype input functions,
>> or their support routines, rather than having it distributed.
> 
> Here's an update with those changes.

This looks good to me.

Did you have any thoughts about what to do with the float types?  I 
guess we could handle those in a separate patch?




pgsql-hackers by date:

Previous
From: "Joel Jacobson"
Date:
Subject: Re: [PATCH] Fix old thinko in formula to compute sweight in numeric_sqrt().
Next
From: Ilya Gladyshev
Date:
Subject: Re: Progress report of CREATE INDEX for nested partitioned tables