Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] PostgresNode::append_conf considered dangerous - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: [HACKERS] PostgresNode::append_conf considered dangerous
Date
Msg-id de19724f-63cb-8298-9cda-298c239984f0@2ndQuadrant.com
Whole thread Raw
In response to [HACKERS] PostgresNode::append_conf considered dangerous  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 

On 04/22/2017 04:19 PM, Tom Lane wrote:
>
> I think instead we should change append_conf to append a newline, and
> simplify the callers that could thereby be simplified.  I don't see
> any callers that would be broken by that; and we do not have any config
> files in which extra blank lines are problematic.
>
>             


+1. Not sure how we survived so long with it the way it is.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [HACKERS] StandbyRecoverPreparedTransactions recovers subtranslinks incorrectly
Next
From: Petr Jelinek
Date:
Subject: Re: [HACKERS] logical replication and PANIC during shutdowncheckpoint in publisher