On Sat, 2024-06-29 at 09:15 +0900, Michael Paquier wrote:
> > Here's a proposed patch for master only. It turns all three situations
> > being reported into ereport(ERROR); in one case I have an XXX comment,
> > because we have an alternative when attaching a partition that already
> > has a PK to a partitioned table that has a non-PK index: just create a
> > separate index in the partition. But that would cause slowness, which
> > is probably undesirable. I'm inclined to just remove the XXX comment,
> > but if anyone has other thoughts, they are welcome.
>
> An error sounds saner here in the long term.
>
> Tests for all of the code paths involved, perhaps? ;)
My example that triggered this assert runs just fine on v16.
So while an error is clearly better than a crash, that would constitute
a regression. Is that really unavoidable? It would be very unfortunate
if the only way to detach a partition would be to drop some indexes first...
Yours,
Laurenz Albe
