Re: make pg_ctl more friendly - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: make pg_ctl more friendly
Date
Msg-id d9525889-c35a-452e-a4c2-b3747fdd6e10@oss.nttdata.com
Whole thread Raw
In response to Re: make pg_ctl more friendly  (Junwang Zhao <zhjwpku@gmail.com>)
Responses Re: make pg_ctl more friendly
List pgsql-hackers

On 2024/07/10 11:45, Junwang Zhao wrote:
>> Attached is my suggestion.
> 
> The patch LGTM.

+            case POSTMASTER_SHUTDOWN_IN_RECOVERY:
+                print_msg(_(" done\n"));
+                print_msg(_("server shut down because of recovery target settings\n"));

"because of recovery target settings" isn't always accurate.
For example, if the DBA shuts down the server during recovery,
POSTMASTER_SHUTDOWN_IN_RECOVERY can be returned regardless of
the recovery target settings. Should we change the message to
something like "server shut down in recovery" for accuracy?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: Proposal for implementing OCSP Stapling in PostgreSQL
Next
From: Tom Lane
Date:
Subject: Re: make pg_ctl more friendly