default_table_access_method is not in sample config file - Mailing list pgsql-hackers

On 11/04/2019 19:49, Andres Freund wrote:
> On 2019-04-11 14:52:40 +0300, Heikki Linnakangas wrote:
>> diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
>> index f7f726b5aec..bbcab9ce31a 100644
>> --- a/src/backend/utils/misc/guc.c
>> +++ b/src/backend/utils/misc/guc.c
>> @@ -3638,7 +3638,7 @@ static struct config_string ConfigureNamesString[] =
>>           {"default_table_access_method", PGC_USERSET, CLIENT_CONN_STATEMENT,
>>               gettext_noop("Sets the default table access method for new tables."),
>>               NULL,
>> -            GUC_IS_NAME
>> +            GUC_NOT_IN_SAMPLE | GUC_IS_NAME
>>           },
>>           &default_table_access_method,
>>           DEFAULT_TABLE_ACCESS_METHOD,
> 
> Hm, I think we should rather add it to sample. That's an oversight, not
> intentional.

I just noticed that this is still an issue. default_table_access_method 
is not in the sample config file, and it's not marked with 
GUC_NOT_IN_SAMPLE. I'll add this to the open items list so we don't forget.

- Heikki