Re: Remove traces of long in dynahash.c - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Remove traces of long in dynahash.c
Date
Msg-id d6fe1d30-082a-48bc-8221-7d5ea5971af0@eisentraut.org
Whole thread Raw
In response to Remove traces of long in dynahash.c  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On 19.08.25 08:24, Michael Paquier wrote:
> While looking at the recent business with dynahash.c in [1], I have
> been reminded of the fact that this code still depends on long.

It's definitely a good idea to get rid of "long" usage.  But you can 
also replace it with long long instead of int64.  I suppose this is a 
stylistic question, but I would tend to use the intNN types only when I 
need exactly that many bits.

Also, your patch changes from signed to unsigned types.  Maybe that's 
ok, but you didn't explain it.




pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: Improve LWLock tranche name visibility across backends
Next
From: Nathan Bossart
Date:
Subject: Re: Remove Instruction Synchronization Barrier in spin_delay() for ARM64 architecture