Re: WaitEventSet resource leakage - Mailing list pgsql-hackers

From Alexander Lakhin
Subject Re: WaitEventSet resource leakage
Date
Msg-id d6c70225-6567-6617-351e-e9cdd73a11af@gmail.com
Whole thread Raw
In response to Re: WaitEventSet resource leakage  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: WaitEventSet resource leakage
List pgsql-hackers
20.11.2023 00:09, Thomas Munro wrote:
> On Fri, Nov 17, 2023 at 12:22 AM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>
>> And here is a patch to implement that on master.
> Rationale and code look good to me.
>
>

I can also confirm that the patches proposed (for master and back branches)
eliminate WES leakage as expected.

Thanks for the fix!

Maybe you would find appropriate to add the comment
/* Convenience wrappers over ResourceOwnerRemember/Forget */
above ResourceOwnerRememberWaitEventSet
just as it's added above ResourceOwnerRememberRelationRef,
ResourceOwnerRememberDSM, ResourceOwnerRememberFile, ...

(As a side note, this fix doesn't resolve the issue #17828 completely,
because that large number of handles might be also consumed
legally.)

Best regards,
Alexander



pgsql-hackers by date:

Previous
From: Ants Aasma
Date:
Subject: Re: autovectorize page checksum code included elsewhere
Next
From: John Naylor
Date:
Subject: Re: Change GUC hashtable to use simplehash?