Re: remaining sql/json patches - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: remaining sql/json patches
Date
Msg-id d506638e-3f5d-df45-7f11-ac797037253c@eisentraut.org
Whole thread Raw
In response to Re: remaining sql/json patches  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: remaining sql/json patches
List pgsql-hackers
On 06.09.23 17:01, Alvaro Herrera wrote:
> Assert()ing that a pointer is not null, and in the next line
> dereferencing that pointer, is useless: the process would crash anyway
> at the time of dereference, so the Assert() adds no value.  Better to
> leave the assert out.

I don't think this is quite correct.  If you dereference a pointer, the 
compiler may assume that it is not null and rearrange code accordingly. 
So it might not crash.  Keeping the assertion would alter that assumption.




pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: proposal: psql: show current user in prompt
Next
From: Peter Eisentraut
Date:
Subject: Re: psql - pager support - using invisible chars for signalling end of report