Re: CREATE TABLE LIKE INCLUDING INDEXES support - Mailing list pgsql-patches

From NikhilS
Subject Re: CREATE TABLE LIKE INCLUDING INDEXES support
Date
Msg-id d3c4af540707160320j6b71ab89v25591c9e7ab7d4d9@mail.gmail.com
Whole thread Raw
In response to Re: CREATE TABLE LIKE INCLUDING INDEXES support  (Neil Conway <neilc@samurai.com>)
Responses Re: CREATE TABLE LIKE INCLUDING INDEXES support
List pgsql-patches
Hi,

> > You suppose "src_options" is much more readable than "inhreloptions"
> > or "inh_idxoptions"? Your call :).
>
> Yeah, I'm not necessarily sure that it is. "inhreloptions" made me think
> of table inheritance, whereas LIKE in general is more of a "source" =>
> "target" copying operation. But I'm not convinced about src_options,
> either ... suggestions/comments welcome.
>

I agree, since its a LIKE operation and not inheritance as such, how about
"src_idxoptions", just to make the reference to the source index
clearer? To reiterate its a minor nitpick really from my side and can
be ignored too.

Regards,
Nikhils
--
EnterpriseDB               http://www.enterprisedb.com

pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Re: CREATE TABLE LIKE INCLUDING INDEXES support
Next
From: Gregory Stark
Date:
Subject: Re: Deferred RI trigger for non-key UPDATEs and subxacts