On 08.07.26 21:24, Haibo Yan wrote:
> I noticed a few places in ecpg that use strncpy() even though the code already
> knows how many bytes to copy.
>
> For example, some paths copy N bytes into a temporary buffer and then add the
> terminating NUL explicitly. There is also one small substring copy in
> pgtypeslib/datetime.c. memcpy() seems a better fit for those cases.
Why is it better? At least strncpy() enforces that the target is a char
array, which memcpy() doesn't.
At a quick glance, strlcpy() might be more suitable in some of the cases
you found.
