Re: pgsql: Add viewBox attribute to storage page layout SVG image - Mailing list pgsql-committers

From Joe Conway
Subject Re: pgsql: Add viewBox attribute to storage page layout SVG image
Date
Msg-id d2cc39e6-2477-30a8-3bff-c69cefb346aa@joeconway.com
Whole thread Raw
In response to Re: pgsql: Add viewBox attribute to storage page layout SVG image  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: pgsql: Add viewBox attribute to storage page layout SVG image  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 4/29/19 2:06 AM, Peter Eisentraut wrote:
> On 2019-04-27 17:37, Joe Conway wrote:
>> Add viewBox attribute to storage page layout SVG image
>
> The SVG images are not supposed to be edited.  This needs a different
> solution.

If the viewBox attribute is needed to make this work reasonably and the
tool does not produce it, post production editing of the SVG is not such
a bad thing IMHO.

But in any case, if you expect that no one will edit a text-based file
(SVG) that is checked in to git, it ought to be made crystal clear
somewhere, and the README is not currently crystal clear on that point.

Additionally, this should go on the issues list for pg12.

Joe
--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development


Attachment

pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Fix potential catalog corruption with temporary identitycolumns
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Add viewBox attribute to storage page layout SVG image