Add tuples_skipped to pg_stat_progress_copy - Mailing list pgsql-hackers

From torikoshia
Subject Add tuples_skipped to pg_stat_progress_copy
Date
Msg-id d12fd8c99adcae2744212cb23feff6ed@oss.nttdata.com
Whole thread Raw
Responses Re: Add tuples_skipped to pg_stat_progress_copy
List pgsql-hackers
Hi,

132de9968840c introduced SAVE_ERROR_TO option to COPY and enabled to 
skip malformed data, but there is no way to watch the number of skipped 
rows during COPY.

Attached patch adds tuples_skipped to pg_stat_progress_copy, which 
counts the number of skipped tuples because source data is malformed.
If SAVE_ERROR_TO is not specified, this column remains zero.

The advantage would be that users can quickly notice and stop COPYing 
when there is a larger amount of skipped data than expected, for 
example.

As described in commit log, it is expected to add more choices for 
SAVE_ERROR_TO like 'log' and using such options may enable us to know 
the number of skipped tuples during COPY, but exposed in 
pg_stat_progress_copy would be easier to monitor.


What do you think?

-- 
Regards,

--
Atsushi Torikoshi
NTT DATA Group Corporation
Attachment

pgsql-hackers by date:

Previous
From: Nisha Moond
Date:
Subject: Re: Synchronizing slots from primary to standby
Next
From: Michael Paquier
Date:
Subject: Re: Make mesage at end-of-recovery less scary.