Re: pg_combinebackup fails on file named INCREMENTAL.* - Mailing list pgsql-hackers

From David Steele
Subject Re: pg_combinebackup fails on file named INCREMENTAL.*
Date
Msg-id d052eded-9ef0-459a-a697-68d5f36d6977@pgmasters.net
Whole thread Raw
In response to Re: pg_combinebackup fails on file named INCREMENTAL.*  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On 4/19/24 01:10, Robert Haas wrote:
> On Wed, Apr 17, 2024 at 7:56 PM David Steele <david@pgmasters.net> wrote:
>> Thanks! I've tested this and it works as advertised.
>>
>> Ideally I'd want an error on backup if there is a similar file in any
>> data directories that would cause an error on combine, but I admit that
>> it is vanishingly rare for users to put files anywhere but the root of
>> PGDATA, so this approach seems OK to me.
> 
> OK, committed. Thanks for the review.

Excellent, thank you!

Regards,
-David



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: plenty code is confused about function level static
Next
From: Dmitry Koval
Date:
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands