On 10/31/16 1:58 AM, Michael Paquier wrote:
> 2) For 0002 and pg_test_fsync, I am seeing a missing entry:
> printf(NA_FORMAT, "n/a*\n");
ok
> 4) 0004 and pg_upgrade... In check.c, three places like that:
> if (!db_used)
> {
> fprintf(script, "Database: %s\n", active_db->db_name);
> db_used = true;
> }
>
> In exec.c:
> #endif
> fprintf(log, "command: %s\n", cmd);
> #ifdef WIN32
These and several of the other places write into log or script files. I
have chosen not to do anything about those for now. That might be a
future change, or we just leave them.
> +GETTEXT_FLAGS = \
> + pg_fatal:1:c-format \
> + pg_log:2:c-format \
> + prep_status:1:c-format \
> + report_stats:2:c-forma
> s/report_stats/report_status/
ok
> In info.c, missing some entries in report_unmatched_relation() when
> reporting unmatching relations?
Yeah, that will need a bit of a rewrite, so FIXME later?
> In util.c, doesn't pg_log_v() need to handle strings used in fprintf?
Which specific lines do you have in mind?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
