Re: Tab completion for CREATE TABLE ... AS - Mailing list pgsql-hackers

From Gilles Darold
Subject Re: Tab completion for CREATE TABLE ... AS
Date
Msg-id cee947e8-a7f4-4589-b1c2-cd0cc956ac77@darold.net
Whole thread Raw
In response to Re: Tab completion for CREATE TABLE ... AS  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Tab completion for CREATE TABLE ... AS
List pgsql-hackers
Le 15/11/2023 à 03:58, Michael Paquier a écrit :
> On Thu, Nov 02, 2023 at 07:27:02PM +0300, Gilles Darold wrote:
>> Look like the tab completion for CREATE TABLE ... AS is not
>> proposed.
>>
>> +    /* Complete CREATE TABLE <name> AS with list of keywords */
>> +    else if (TailMatches("CREATE", "TABLE", MatchAny, "AS") ||
>> +             TailMatches("CREATE", "TEMP|TEMPORARY|UNLOGGED", "TABLE", MatchAny, "AS"))
>> +        COMPLETE_WITH("SELECT", "WITH");
> There is a bit more than SELECT and WITH as possible query for a CTAS.
> How about VALUES, TABLE or even EXECUTE (itself able to handle a
> SELECT, TABLE or VALUES)?
> --
> Michael

Right, I don't know how I have missed the sql-createtableas page in the 
documentation.

Patched v2 fixes the keyword list, I have also sorted by alphabetical 
order the CREATE TABLE completion (AS was at the end of the list).

It has also been re-based on current master.

-- 
Gilles Darold
http://www.darold.net/

Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Allow tests to pass in OpenSSL FIPS mode
Next
From: Julien Rouhaud
Date:
Subject: Re: Fix documentation for pg_stat_statements JIT deform_counter