about allow_system_table_mods and SET STATISTICS - Mailing list pgsql-hackers

From Peter Eisentraut
Subject about allow_system_table_mods and SET STATISTICS
Date
Msg-id cc8d2648-a0ec-7a86-13e5-db473484e19e@2ndquadrant.com
Whole thread Raw
Responses Re: about allow_system_table_mods and SET STATISTICS  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Until PostgreSQL 9.1, it was possible to run ALTER TABLE ... SET 
STATISTICS without allow_system_table_mods.  In PostgreSQL 9.2 and 
later, this no longer works.  This change was apparently accidental.  (I 
gave up after a while trying to bisect it exactly, but probably 
something related to 1489e2f26a4c0318938b3085f50976512f321d84.)

(It didn't work on mapped relations, so it wasn't all roses.)

A comment in ATPrepSetStatistics() still makes references to this being 
possible.  I propose to remove this comment.

There was some discussion about (re-)allowing this and some other 
commands like this, but after the recent changes to make 
allow_system_table_mods easier to use, I think this has less urgency, so 
I'd rather get the comment correct in the meantime.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: adding strndup
Next
From: Peter Eisentraut
Date:
Subject: Re: Update minimum SSL version