Re: psql metaqueries with \gexec - Mailing list pgsql-hackers

From Daniel Verite
Subject Re: psql metaqueries with \gexec
Date
Msg-id cbf9a1c4-8229-4303-9b17-61a6f3314cbd@mm
Whole thread Raw
In response to Re: psql metaqueries with \gexec  (Corey Huinker <corey.huinker@gmail.com>)
Responses Re: psql metaqueries with \gexec
List pgsql-hackers
    Corey Huinker wrote:

> ...and query text visibility, and result visibility, and error handling,
> etc. In this case, we're leveraging the psql environment we'd already set
> up, and if there's an error, \set ECHO queries shows us the errant SQL as
> if we typed it ourselves..

BTW, about error handling, shouldn't it honor ON_ERROR_STOP ?

With the patch when trying this:

=> set ON_ERROR_STOP on
=> select * from (values ('select 1/0', 'select 1/0')) AS n \gexec

it produces two errors:
ERROR:    division by zero
ERROR:    division by zero

I'd rather have the execution stop immediately after the first error,
like it's the case with successive queries entered normally via the
query buffer:

=> \set ON_ERROR_STOP on
=> select 1/0; select 1/0;
ERROR:    division by zero

as opposed to:

=> \set ON_ERROR_STOP off
=> select 1/0; select 1/0;
ERROR:    division by zero
ERROR:    division by zero


Best regards,
--
Daniel Vérité
PostgreSQL-powered mailer: http://www.manitou-mail.org
Twitter: @DanielVerite



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Add some isolation tests for deadlock detection and resolution.
Next
From: Alvaro Herrera
Date:
Subject: Re: Writing new unit tests with PostgresNode