Re: Take skip header out of a loop in COPY FROM - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Take skip header out of a loop in COPY FROM
Date
Msg-id cbe02650-f502-1743-72e8-a93cc51313fd@iki.fi
Whole thread Raw
In response to Take skip header out of a loop in COPY FROM  (Surafel Temesgen <surafel3000@gmail.com>)
Responses Re: Take skip header out of a loop in COPY FROM  (Adam Lee <ali@pivotal.io>)
List pgsql-hackers
On 22/08/2019 11:31, Surafel Temesgen wrote:
> Hello,
> 
> Even if skipping header is done only once its checked and skipped in a 
> loop. If I don’t miss something it can be done out side a loop like 
> attached patch

You may be on to something, but if we move it to CopyFrom(), as in your 
patch, then it won't get executed e.g. from the calls in file_fdw. 
file_fdw calls BeginCopyFrom(), followed by NextCopyFrom(); it doesn't 
use CopyFrom().

- Heikki



pgsql-hackers by date:

Previous
From: Surafel Temesgen
Date:
Subject: Take skip header out of a loop in COPY FROM
Next
From: Peter Eisentraut
Date:
Subject: Re: Make SQL/JSON error code names match SQL standard