Re: _isnan() on Windows - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: _isnan() on Windows
Date
Msg-id caf0568e-3c1f-07fd-6914-d903f22560f2@2ndQuadrant.com
Whole thread Raw
In response to Re: _isnan() on Windows  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: _isnan() on Windows  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers

On 07/12/2018 10:38 AM, Tom Lane wrote:
> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> On 07/12/2018 10:20 AM, Tom Lane wrote:
>>> bowerbird and hamerkop have some gripes like this:
>>>
>>> bowerbird     | c:\perl64\lib\core\win32.h(218): warning C4005: 'isnan' : macro redefinition (src/pl/plperl/SPI.c)
[G:\prog\bf\root\HEAD\pgsql.build\plperl.vcxproj]
>> We actually undef a bunch of things in plperl.h to keep the compiler
>> quiet. Maybe we need to add this to the list?
> Perhaps.  But how do we tell the platforms where we should do that
> from the ones where we shouldn't?
>
>             

In the _MSCVER section:

#ifdef isnan
#undef isnan
#endif

By inspection the perl header is just defining it to _isnan, for every 
MSC version.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Failure assertion in GROUPS mode of window function in current HEAD
Next
From: Masahiko Sawada
Date:
Subject: Re: Failure assertion in GROUPS mode of window function in current HEAD