Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line - Mailing list pgsql-hackers

From Alexey Kondratov
Subject Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line
Date
Msg-id c9cfabce-8fb6-493f-68ec-e0a72d957bf4@postgrespro.ru
Whole thread Raw
In response to Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line  (Alexey Kondratov <a.kondratov@postgrespro.ru>)
Responses Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line  (Andrey Borodin <x4mmm@yandex-team.ru>)
List pgsql-hackers
Hi,

>
> I will work out this one with postgres -C and come back till the next 
> commitfest. I found that something similar is already used in pg_ctl 
> and there is a mechanism for finding valid executables in exec.c. So 
> it does not seem to be a big deal at the first sight.
>

I have reworked the patch, please find new version attached. It is 3 
times as smaller than the previous one and now touches pg_rewind's code 
only. Tests are also slightly refactored in order to remove duplicated 
code. Execution of postgres -C is used for restore_command retrieval (if 
-r is passed) as being suggested. Otherwise everything works as before.

Andres, Alvaro does it make sense now?



Regards

-- 
Alexey Kondratov

Postgres Professional https://www.postgrespro.com
Russian Postgres Company


Attachment

pgsql-hackers by date:

Previous
From: Christoph Berg
Date:
Subject: Re: [HACKERS] Time to change pg_regress diffs to unified by default?
Next
From: Michael Meskes
Date:
Subject: Re: SQL statement PREPARE does not work in ECPG