Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented - Mailing list pgsql-hackers

2021-09-28 17:06 に bt21tanigaway さんは書きました:
> 2021-09-28 17:03 に bt21tanigaway さんは書きました:
>> 2021-09-28 16:36 に Fujii Masao さんは書きました:
>>> On 2021/09/28 16:13, bt21tanigaway wrote:
>>>> Hi,
>>>> 
>>>> (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented in 
>>>> tab-complete. I made a patch for these options.
>>> 
>>> Thanks for the patch!
>>> The patch seems to forget to handle the tab-completion for
>>> "LOCK ONLY <table-name> IN".
>> 
>> Thanks for your comment!
>> I attach a new patch fixed to this mail.
>> 
>> Regards,
>> 
>> Koyu Tanigawa
> 
> Sorry, I forgot to attach patch file.
> "fix-tab-complete2.patch" is fixed!
> 
> Regards,
> 
> Koyu Tanigawa
Thank you for your patch.
I have two comments.

1. When I executed git apply, an error occured.
---
$ git apply ~/Downloads/fix-tab-complete2.patch
/home/penguin/Downloads/fix-tab-complete2.patch:14: indent with spaces.
     COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_tables, " UNION SELECT 
'TABLE'" " UNION SELECT 'ONLY'");
warning: 1 line adds whitespace errors.
---

2. The command "LOCK TABLE a, b;" can be executed, but tab-completion 
doesn't work properly. Is it OK?

-- 
Regards,

--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION