Re: [COMMITTERS] 'pgsql/src/backend/parser gram.y parse_oper.c' - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [COMMITTERS] 'pgsql/src/backend/parser gram.y parse_oper.c'
Date
Msg-id c9862e9cb5a4abcb454a3ce10a4102af
Whole thread Raw
List pgsql-hackers
>
> > > Update of /usr/local/cvsroot/pgsql/src/backend/parser
> > > In directory hub.org:/home/users/t/thomas/pgsql/src/backend/parser
> > >
> > > Modified Files:
> > >       gram.y parse_oper.c
> > > Log Message:
> > > Change precedence for boolean operators to match expected behavior.
> > > Change NOTICE/NOTICE/NOTICE/WARN elog messages to a single message
> > >  with a few newline/tab breaks embedded in the string. Much cleaner I hope.
> >
> > I never liked the WARN message.  Basically, it is not a warning, but an
> > error, and the statement is not executed.  Is this changed now, or
> > should we change it.
>
> I changed it to a single WARN. The type of error it is signalling is similar to
> other errors which are flagged as "WARN". Is there another level of message you
> are suggesting we use? FATAL closes the backend doesn't it?

I just think the WARN word coming up on users terminals is odd.  I can
make the change in all the source files easily if we decide what the new
error word should be.  Error?  Failure?

- --
Bruce Momjian
maillist@candle.pha.pa.us

------------------------------

End of hackers-digest V1 #592
*****************************

pgsql-hackers by date:

Previous
From: "Thomas G. Lockhart"
Date:
Subject: Current regression tests
Next
From: Peter T Mount
Date:
Subject: Has anyone come across this problem with JDBC?