Re: pgsql: Replace PostmasterRandom() with a stronger source, second attemp - Mailing list pgsql-committers

From Heikki Linnakangas
Subject Re: pgsql: Replace PostmasterRandom() with a stronger source, second attemp
Date
Msg-id c8aeac67-d964-5559-8ead-f08f41df0467@iki.fi
Whole thread Raw
In response to Re: pgsql: Replace PostmasterRandom() with a stronger source, second attemp  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-committers
On 12/07/2016 02:30 AM, Michael Paquier wrote:
> With the logs complaining as well:
> [1-1] db=[unknown],user=[unknown],app=[unknown],client=[local] LOG:
> wrong key in cancel request for process 57361
>
> As far as I can see processCancelRequest uses a long variable, and it
> gets compared with an int32. MyCancelKey has been changed to an int32
> in globals.c with the above commit. So on 64b machines the current
> code is aimed to fail. Attached is a patch to fix the issue.

Pushed, thanks!

- Heikki



pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix query cancellation.
Next
From: Tom Lane
Date:
Subject: pgsql: Handle empty or all-blank PAGER setting more sanely in psql.