Re: Translation of the NextOID message in pg_controldata - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Translation of the NextOID message in pg_controldata
Date
Msg-id c86afb31-3250-4400-9b10-1e67f4eb5c1a@eisentraut.org
Whole thread
In response to Re: Translation of the NextOID message in pg_controldata  (Michael Paquier <michael@paquier.xyz>)
Responses Re: sequencesync worker race with REFRESH SEQUENCES
List pgsql-hackers
On 14.09.26 09:08, Michael Paquier wrote:
> On Mon, Sep 14, 2026 at 08:41:59AM +0200, Alvaro Herrera wrote:
>> I'm not sure I understand why we care that we hardcode that Oid8 is the
>> same as uint64.  It's never been a problem that Oid is the same as uin32 ...
> 
> For me, the reason is greppability of oid8 information as the
> variables printed in the strings may not refer to variables declared
> in the code.

I don't understand what this means.  Do you mean you want to grep for 
where an oid8 value is being printed?  I mean, that just won't work.  We 
don't accommodate that in the code for anything else in place of "oid8".

I think the symbol OID8_FORMAT should be purged from the code.  Its 
presence is just going to cause confusion, with people using it in 
incorrect ways, and inviting more XXX_FORMAT symbols to be added.  We 
have just been working on getting rid of these after all.





Attachment

pgsql-hackers by date:

Previous
From: Andrey Borodin
Date:
Subject: Re: Checkpointer write combining
Next
From: shihao zhong
Date:
Subject: Re: GIN index fast list search may become un-interruptible for long time.