Re: New GUC to sample log queries - Mailing list pgsql-hackers

From Adrien Nayrat
Subject Re: New GUC to sample log queries
Date
Msg-id c80bad2d-c865-5bf2-71b9-fa95127d34f9@anayrat.info
Whole thread Raw
In response to Re: New GUC to sample log queries  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: New GUC to sample log queries
List pgsql-hackers
On 11/29/18 6:35 PM, Alvaro Herrera wrote:
> 
> Sounds good to me (we -> you, I suppose?).  I'd tweak the extra_desc for
> log_min_duration_statement too, because we no longer log "all" when the
> rate is <1; maybe "Zero prints all queries, subject to
> log_statement_sample_rate.  -1 turns this feature off."

Right, I also changed a part of log_min_duration_statement documentation to
mention log_statement_sample_rate

> 
> I just noticed we don't use "you" anywhere in the descs, except for this
> one:

Maybe we could change with something like this :

long_desc: "Take a value between 0 (never log) and 1.0 (always log) to log a
sample."


Thanks,

Attachment

pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: pg_config wrongly marked as not parallel safe?
Next
From: Robert Haas
Date:
Subject: Re: pg_config wrongly marked as not parallel safe?