Makefile.shlib functionality on win32 - Mailing list pgsql-hackers

From Thomas Hallgren
Subject Makefile.shlib functionality on win32
Date
Msg-id c7e9k8$t1n$1@news.hub.org
Whole thread Raw
Responses Re: Makefile.shlib functionality on win32
List pgsql-hackers
I have a minor problem. I'd like to use the Makefile.shlib that comes with
PostgreSQL when creating the pljava.dll. Due to the way native methods are
linked in Java, I need to use the dlltool option "--add-stdcall-alias" when
I create the dll definition file. In the Makefile.shlib, the dlltool for
cygwin and win32 is invoked as:
$(DLLTOOL) --export-all --output-def $(NAME).def $(OBJS)

in other words, there's no place to add extra options. I'd like it to be:

$(DLLTOOL) --export-all $(DLLTOOL_DEFFLAGS) --output-def $(NAME).def $(OBJS)

where DLLTOOL_DEFFLAGS is empty per default. The name DLLTOOL_DEFFLAGS is
chosen so that a DLLTOOL_LIBFLAGS could be added for the second dlltool
invokation that produces the lib. A DLLWRAP_FLAGS extending the dllwrap
invocation could be added as well (I don't need the latter two but I think
they should be added for consistency).

Is such a patch something that could be accepted?

regards,

Thomas Hallgren



pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: More Hashing questions
Next
From: "Darko Prenosil"
Date:
Subject: Re: Bug in pg_dump 7.4