Re: Nondeterministic collations vs. text_pattern_ops - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Nondeterministic collations vs. text_pattern_ops
Date
Msg-id c7e57eaf-5d7f-22b6-6f48-85580889de8d@2ndquadrant.com
Whole thread Raw
In response to Re: Nondeterministic collations vs. text_pattern_ops  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Nondeterministic collations vs. text_pattern_ops
List pgsql-hackers
On 2019-09-17 17:17, Tom Lane wrote:
> My recommendation is to get rid of the run-time checks and instead
> put a hack like this into DefineIndex or some minion thereof:
> 
>     if ((opclass == TEXT_PATTERN_BTREE_CLASS_OID ||
>          opclass == VARCHAR_PATTERN_BTREE_CLASS_OID ||
>          opclass == BPCHAR_PATTERN_BTREE_CLASS_OID) &&
>         !get_collation_isdeterministic(collid))
>        ereport(ERROR, ...);

Here is a draft patch.

It will require a catversion change because those operator classes don't
have assigned OIDs so far.

The comment block I just moved over for the time being.  It should
probably be rephrased a bit.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Ahsan Hadi
Date:
Subject: Re: enhance SPI to support EXECUTE commands
Next
From: Alexey Kondratov
Date:
Subject: Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace onthe fly