On 2022/07/16 11:36, Michael Paquier wrote:
> I was thinking about doing that only on HEAD. One thing interesting
> about this patch is that it can also be used as a point of reference
> for other future things.
Ok, here are review comments:
+my $connstr =
+ $node->connstr('postgres') . " replication=database dbname=postgres";
Since the result of connstr() includes "dbname=postgres", you don't need to add "dbname=postgres" again.
+# The psql command should fail on pg_stop_backup().
Typo: s/pg_stop_backup/pg_stop_backup
I reported two trouble cases; they are the cases where BASE_BACKUP is canceled and terminated, respectively. But you
addedthe test only for one of them. Is this intentional?
>> Since one of them failed to be applied to v14 or before cleanly, I
>> also created the patch for those back branches. So I attached three
>> patches.
>
> Fine by me.
I pushed these bugfix patches at first. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
