Re: Spurious pgstat_drop_replslot() call - Mailing list pgsql-hackers

From Alexander Lakhin
Subject Re: Spurious pgstat_drop_replslot() call
Date
Msg-id c53cfa16-9306-24db-2cc1-6303b8f8e959@gmail.com
Whole thread Raw
In response to Re: Spurious pgstat_drop_replslot() call  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
Responses Re: Spurious pgstat_drop_replslot() call
List pgsql-hackers
Hello Bertrand and Michael,

12.03.2024 09:17, Bertrand Drouvot wrote:
>
>> May I
>> suggest the attached additions with LWLockHeldByMeInMode to make sure
>> that the stats are dropped and created while we hold
>> ReplicationSlotAllocationLock?
> Yeah, makes fully sense and looks good to me.

Sorry for a bit off-topic, but I've remembered an anomaly with a similar
assert:
https://www.postgresql.org/message-id/17947-b9554521ad963c9c%40postgresql.org

Maybe you would find it worth considering while working in this area...
(I've just run that reproducer on b36fbd9f8 and confirmed that the
assertion failure is still here.)

Best regards,
Alexander



pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: Statistics Import and Export
Next
From: Alvaro Herrera
Date:
Subject: Re: [EXTERNAL] Re: Add non-blocking version of PQcancel