Re: Fix most -Wundef warnings - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Fix most -Wundef warnings
Date
Msg-id c411bc52-60d3-cef0-f4ca-58fc96450d04@2ndquadrant.com
Whole thread Raw
In response to Re: Fix most -Wundef warnings  (Mark Dilger <hornschnorter@gmail.com>)
List pgsql-hackers
On 2019-10-14 17:12, Mark Dilger wrote:
> The check on HSTORE_IS_HSTORE_NEW goes back at least as far as 2006, 
> suggesting it was needed for migrating from some version pre-9.0, making 
> me wonder if anybody would need this in the field.  Should we drop 
> support for this?  I don't have a strong reason to advocate dropping 
> support other than that this #define appears to be undocumented.

Per subsequent messages in this thread, this issue is outside the scope
of my patch, so I proceeded with my patch as I had proposed it.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Fix most -Wundef warnings
Next
From: Peter Eisentraut
Date:
Subject: Re: Add a GUC variable that control logical replication