Re: [PATCH] pglister: Add possibility to override settings.py in settings_local.py - Mailing list pgsql-www

From Célestin Matte
Subject Re: [PATCH] pglister: Add possibility to override settings.py in settings_local.py
Date
Msg-id c404df0f-0f6b-f513-fa52-0edc2e569be6@cmatte.me
Whole thread Raw
In response to Re: [PATCH] pglister: Add possibility to override settings.py in settings_local.py  (Magnus Hagander <magnus@hagander.net>)
Responses Re: [PATCH] pglister: Add possibility to override settings.py in settings_local.py  (Magnus Hagander <magnus@hagander.net>)
List pgsql-www
Hello,

> 
> And finally, settings.py already contains:
> try:
>     from .local_settings import *
> except ImportError:
>     pass
> 
> 
> Just a couple of lines above where you are adding it back again. Is that also for some reason not working?

Right, I missed that. It's just that in pgweb and pgarchives, the file is called settings_local.py, whereas pglister
callsit local_settings.py. This is just a question of naming consistency, then. Do you think it's worth patching?
 

> Second, I'm not sure why we want to exclude local_settings.py from pycodestyle in general?

It's ignored in pgweb, I just assumed there was a good reason for that and did the same thing for consistency.

Cheers,
-- 
Célestin Matte



pgsql-www by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: [PATCH] pglister: Add possibility to override settings.py in settings_local.py
Next
From: Daniel Gustafsson
Date:
Subject: Warning on snapshot downloads