Re: Asynchronous MergeAppend - Mailing list pgsql-hackers

From Alexander Pyhalov
Subject Re: Asynchronous MergeAppend
Date
Msg-id c264abe661f72d6627f987fc9aa4e456@postgrespro.ru
Whole thread Raw
In response to Re: Asynchronous MergeAppend  ("Matheus Alcantara" <matheusssilv97@gmail.com>)
Responses Re: Asynchronous MergeAppend
List pgsql-hackers
Matheus Alcantara писал(а) 2025-12-29 16:43:
> On Tue Dec 23, 2025 at 5:50 AM -03, Alexander Pyhalov wrote:
>> I've looked through updated patch. Tested it (also with our fdw).
>> Overall looks good.
>> 
> Thanks for testing.
> 
>> In execAppend.c there's still reference to as_valid_subplans. Also we
>> could perhaps use palloc0_array() in some more places, for example, 
>> for
>> for state->asyncrequests and state->asyncresults.
>> 
> Fixed on the new attached version.
> 
> --
> Matheus Alcantara
> EDB: https://www.enterprisedb.com

Hi.

Looks good. What do you think about classify_matching_subplans_common()? 
Should it stay where it is or should we hide it to
src/include/executor/execAppend.h ?
-- 
Best regards,
Alexander Pyhalov,
Postgres Professional



pgsql-hackers by date:

Previous
From: Kirill Reshke
Date:
Subject: REASSIGN OWNED BY alters objects in other database.
Next
From: Kirill Reshke
Date:
Subject: Re: REASSIGN OWNED BY alters objects in other database.