Re: Asynchronous MergeAppend - Mailing list pgsql-hackers

From Alexander Pyhalov
Subject Re: Asynchronous MergeAppend
Date
Msg-id c0d55d3f68bfd5650fe3143d3a31c84c@postgrespro.ru
Whole thread Raw
In response to Re: Asynchronous MergeAppend  ("Matheus Alcantara" <matheusssilv97@gmail.com>)
List pgsql-hackers
Matheus Alcantara писал(а) 2025-12-30 18:04:
> On Tue Dec 30, 2025 at 10:15 AM -03, Alexander Pyhalov wrote:
>> Looks good. What do you think about 
>> classify_matching_subplans_common()?
>> Should it stay where it is or should we hide it to
>> src/include/executor/execAppend.h ?
>> 
> Yeah, sounds better to me to move classify_matching_subplans_common to
> execAppend.h since it very specific for the MergeAppend and Append
> execution. I've declared the function as static inline on execAppend.h
> but I'm not sure if it's the best approach.
> 
> I've also wrote a proper commit message for this new version.

Looks good to me.

-- 
Best regards,
Alexander Pyhalov,
Postgres Professional



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Assertion failure in SnapBuildInitialSnapshot()
Next
From: Masahiko Sawada
Date:
Subject: Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE