On 7/2/26 07:06, Palak Chaturvedi wrote:
> Hi Tomas,
>
> Thanks for these test patches. They are quite useful. I've been going
> through them because we think they'll also help with the TAP tests for
> the online shared_buffers resize work , where I'm ending up reusing
> several of the same helpers (attach_injection_points,
> background_rw_pgbench, and a couple of others).
> Would you be open to lifting these helpers out into a shared Perl module
> (for example under src/test/perl/PostgreSQL/Test/…) so both test suites
> can consume them instead of each copy-pasting? I'm happy to prepare a
> small prep patch on top of your latest version if that sounds reasonable
> to you.
>
I suppose you mean the functions for managing injection points (waiting,
waking, attachin/detaching, ...)? Yes, it might be useful to have that
in a Perl module, so feel free to create one.
regards
--
Tomas Vondra
