Re: pgsql: Refactor dlopen() support - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: pgsql: Refactor dlopen() support
Date
Msg-id beaac5d2-33e4-0d60-5e7a-72fb034e35a9@2ndquadrant.com
Whole thread Raw
In response to Re: pgsql: Refactor dlopen() support  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Refactor dlopen() support  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 07/09/2018 16:19, Tom Lane wrote:
> Somehow or other, the changes you made in dfmgr.c's #include lines
> have made it so that find_rendezvous_variable's local "bool found"
> variable is actually of type _Bool (which is word-wide on these
> machines).  However, hash_search thinks its output variable is
> of type pointer to "typedef char bool".  The proximate cause of
> the observed failure is that find_rendezvous_variable sees "found"
> as true when it should not, and thus fails to zero out the variable's
> value.

Ah because dlfcn.h includes stdbool.h.  Hmm.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Maksim Milyutin
Date:
Subject: Re: Hint to set owner for tablespace directory
Next
From: Andres Freund
Date:
Subject: Re: [PATCH] Fix for infinite signal loop in parallel scan