Re: [HACKERS] 6.1 progress - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [HACKERS] 6.1 progress
Date
Msg-id bdd81a7f47789a39582c38876ddadb18
Whole thread Raw
In response to [HACKERS] 6.1 progress  (Bruce Momjian <maillist@candle.pha.pa.us>)
List pgsql-hackers
>
> On Mon, 2 Jun 1997, Bruce Momjian wrote:
>
> > >
> > > Well, one of the leaks that Purify detected was that individual lines read
> > > from files were malloc'ed but not freed properly. So, if a line is
> > > malloc'ed to about 8K (and we are reading thousands of lines in COPY reg
> > > test I believe) and is not freed before next line is read, we get
> > > significant memory usage... Plus adding all other leaks we get into major
> > > problems...
> > >
> > > I fixed the 'lines' leak so we shall see what happens...The backend should
> > > be interesting...
> >
> > Because of the postgresql memory manager, some of the leaks are
> > auto-cleaned after every statement/transaction, so it may not be too
> > bad.  Or it may be.
>
>     Actually, that would only free up memory for the backend, no?  I
> think the problem that Igor is reporting is that in psql itself, we are
> doing (if I remember the patch correctly):
>
>     line = malloc();
>     fgets(line);
>
>     But never did a free(line); after we were finished with the
> data in line, just assigning a new memory segment to it...

Yes, Igor is talking about psql and libpq.  I was discussing the
potential problems he may or may not find in the backend.

- --
Bruce Momjian
maillist@candle.pha.pa.us

------------------------------

pgsql-hackers by date:

Previous
From: The Hermit Hacker
Date:
Subject: Re: [HACKERS] 6.1 progress
Next
From: Igor
Date:
Subject: Re: [HACKERS] 6.1 progress