Re: display hot standby state in psql prompt - Mailing list pgsql-hackers

From Jim Jones
Subject Re: display hot standby state in psql prompt
Date
Msg-id bc9be152-ca08-41f1-800f-d78fd38c75cb@uni-muenster.de
Whole thread Raw
In response to Re: display hot standby state in psql prompt  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers

On 27/10/2025 04:32, Fujii Masao wrote:
> I think the "hs &&" and "ro &&" checks are no longer needed,
> since we've already confirmed they're not NULL at that point.

Right. Checks removed.

> Also, should "unknown" be marked for translation, as in the \conninfo code?
> I'm not sure whether showing a translated string in the psql prompt is
> desirable, though.

Here I am not sure if it's applicable. In this file there are other
strings that are not marked for translation, "abort", "on", "off". I
changed the string to _("unknown") for now, but we can remove it in
further iterations if we agree it's not desirable :)

v5 attached.

Thanks for the review.

Best, Jim


Attachment

pgsql-hackers by date:

Previous
From: Jakub Wartak
Date:
Subject: Re: [PATCH] Add Windows support for backtrace_functions (MSVC only)
Next
From: jian he
Date:
Subject: COPY WHERE clause generated/system column reference