On 27.03.26 14:23, Bertrand Drouvot wrote:
> Hi,
>
> On Fri, Mar 27, 2026 at 01:15:29PM +0100, Peter Eisentraut wrote:
>> On 27.03.26 11:07, Bertrand Drouvot wrote:
>>> That looks ok but I wonder if we should also add '-Werror=vla' to it (
>>> and remove it from common_warning_flags) to be in sync with what configure.ac
>>> is doing:
>>>
>>> "
>>> PGAC_PROG_CC_CFLAGS_OPT([-Werror=vla])
>>> # -Wvla is not applicable for C++
>>> "
>>
>> Hmm. This comment is not actually fully correct. With g++, you can write a
>> VLA and it will work, and also -Wvla will warn about it. So we should
>> actually add that option to C++ as well. (It is true that VLAs are not in
>> standard C++, and g++ with -pedantic will also warn about it.)
>
> Oh right, just did a few tests and agree with your comment above. I agree that
> it should also be added for C++ in autoconf then.
>
> What about the attached?
>
> That said, your patch LGTM given that the VLA remark was not appropriate.
Ok, both committed.
