Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOASTtable does not exist - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOASTtable does not exist
Date
Msg-id b9fd08ee-dda2-765f-18b1-08a1b810fe19@2ndquadrant.com
Whole thread Raw
In response to Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOAST table does not exist  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOASTtable does not exist
Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOAST table does not exist
List pgsql-hackers
On 1/18/18 18:42, Tom Lane wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> On Wed, Jan 17, 2018 at 3:50 PM, Nikolay Shaplov <dhyan@nataraj.su> wrote:
>>> This patch raises error if user tries o set or change toast.* option for a
>>> table that does not have a TOST relation.

> There might be a case for raising a warning in this situation,
> but I would disagree with making it a hard error in any case.
> All that's going to accomplish is to break people's scripts and
> get them mad at you.

It might also be useful to set these reloptions before you add a new
column to a table.

So I think this change is not desirable.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: PATCH: Configurable file mode mask
Next
From: Peter Eisentraut
Date:
Subject: Re: Test-cases for exclusion constraints is missing inalter_table.sql file