Hi Thomas,
21.10.2023 08:26, Thomas Munro wrote:
> And concretely this would be the fix, I think. But I don't have
> Windows, and for reasons I haven't fathomed I haven't yet managed to
> reproduce it by pushing a change of default min_dynamic_shared_memory
> to CI. Is there any chance that a Postgres hacker on Windows could
> confirm the above theory, and that the attached fixes it?
I've tried on master:
echo min_dynamic_shared_memory = 10MB >c:\temp\extra.config
set TEMP_CONFIG=c:\temp\extra.config
vcregress check
and got:
...
Installation complete.
# initializing database system by running initdb
# postmaster failed, examine ".../src/test/regress/log/postmaster.log" for the reasonBail out!
>cat ../../../src/test/regress/log/postmaster.log
2023-10-20 23:12:46.110 PDT postmaster[3140] LOG: starting PostgreSQL 17devel, compiled by Visual C++ build 1928,
64-bit
2023-10-20 23:12:46.113 PDT postmaster[3140] LOG: listening on IPv6 address "::1", port 55312
2023-10-20 23:12:46.113 PDT postmaster[3140] LOG: listening on IPv4 address "127.0.0.1", port 55312
2023-10-20 23:12:46.129 PDT startup[6188] LOG: database system was shut down at 2023-10-20 23:12:41 PDT
2023-10-20 23:12:46.130 PDT startup[6188] FATAL: could not duplicate handle for "Global/PostgreSQL.753594369": Bad
file
descriptor
2023-10-20 23:12:46.132 PDT postmaster[3140] LOG: startup process (PID 6188) exited with exit code 1
2023-10-20 23:12:46.132 PDT postmaster[3140] LOG: aborting startup due to startup process failure
2023-10-20 23:12:46.132 PDT postmaster[3140] LOG: database system is shut down
With your patch applied, `vcregress check` passes just fine.
Best regards,
Alexander
