Re: [19] CREATE SUBSCRIPTION ... SERVER - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: [19] CREATE SUBSCRIPTION ... SERVER
Date
Msg-id b881ea575dab426422e483ab7edfcd98b532cbef.camel@j-davis.com
Whole thread Raw
In response to Re: [19] CREATE SUBSCRIPTION ... SERVER  (Jeff Davis <pgsql@j-davis.com>)
Responses Re: [19] CREATE SUBSCRIPTION ... SERVER
List pgsql-hackers
On Thu, 2026-02-26 at 11:12 -0800, Jeff Davis wrote:
> On Wed, 2026-02-04 at 13:53 +0900, Masahiko Sawada wrote:
> > I've reviewed the latest patch set. I understand the motivation
> > behind
> > this proposal and find it useful.
>
> Thank you, that's important feedback.

Attached v18:

  * rebase
  * Changed ForeignServerConnectionString() to use a local variable
rather than a static. It's not very performance-sensitive, so it's OK
to create a memory context for each invocation, which will be deleted.
I'm not aware of an actual problem in the previous code, but it seemed
a bit less safe.

I plan to commit the main patch (v18-0001) soon, after rechecking some
details (like the postgres_fdw upgrade). v18-0002 could use some review
first.

Regards,
    Jeff Davis


Attachment

pgsql-hackers by date:

Previous
From: "Greg Burd"
Date:
Subject: Re: Areas for Solaris support modernization
Next
From: Zsolt Parragi
Date:
Subject: Re: Hash-based MCV matching for large IN-lists