Re: Add PQsendSyncMessage() to libpq - Mailing list pgsql-hackers

From Anton Kirilov
Subject Re: Add PQsendSyncMessage() to libpq
Date
Msg-id b878b8d2-8481-4fde-a374-5ccb9168d4e4@gmail.com
Whole thread Raw
In response to Re: Add PQsendSyncMessage() to libpq  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Add PQsendSyncMessage() to libpq
Re: Add PQsendSyncMessage() to libpq
List pgsql-hackers
Hello,

Thanks for the feedback!

On 07/11/2023 09:23, Jelte Fennema-Nio wrote:
 > But I think it's looking at the situation from the wrong direction. 
[...] we should look at it as an addition to our current list of PQsend 
functions for a new packet type. And none of those PQsend functions ever 
needed a flag. Which makes sense, because they are the lowest level 
building blocks that make sense from a user perspective: They send a 
message type over the socket and don't do anything else.

Yes, I think that this is quite close to my thinking when I created the 
original version of the patch. Also, the protocol specification states 
that the Sync message lacks parameters.

Since there haven't been any comments from the other people who have 
chimed in on this e-mail thread, I will assume that there is consensus 
(we are doing a U-turn with the implementation approach after all), so 
here is the updated version of the patch.

Best wishes,
Anton Kirilov
Attachment

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: proposal: possibility to read dumped table's name from file
Next
From: Andrew Dunstan
Date:
Subject: Re: pg_basebackup check vs Windows file path limits