Hello Amit,
07.06.2019 7:30, Amit Kapila wrote:
> Leaving the changes related to the above two points, I have combined
> all the changes and fixed the things as per my review in the attached
> patch. Alexander, see if you can verify once the combined patch. I
> am planning to commit the attached by tomorrow and then we can deal
> with the remaining two. However, in the meantime, if Andres shared
> his views on the above two points, then we can include the changes
> corresponding to them as well.
Amit, I agree with all of your changes. All I could is to move a dot:
.. (see contrib/postgres_fdw/postgres_fdw.c: postgresBeginDirectModify()
as one example).
Best regards,
Alexander
