Re: [PATCH] pg_ctl should not truncate command lines at 1024 characters - Mailing list pgsql-hackers

From Phil Krylov
Subject Re: [PATCH] pg_ctl should not truncate command lines at 1024 characters
Date
Msg-id b6de877995242870dbff8286f76b7ffa@krylov.eu
Whole thread Raw
In response to Re: [PATCH] pg_ctl should not truncate command lines at 1024 characters  (Ranier Vilela <ranier.vf@gmail.com>)
List pgsql-hackers
On 2021-09-03 00:36, Ranier Vilela wrote:

> The msvc docs says that limit for the command line is 32,767 
> characters,
> while ok for me, I think if not it would be better to check this limit?

Well, it's ARG_MAX in POSIX, and ARG_MAX is defined as 256K in Darwin, 
512K in FreeBSD, 128K in Linux; _POSIX_ARG_MAX is defined as 4096 on all 
three platforms. Windows may differ too. Anyways, allocating even 128K 
in precious stack space is too much, that's why I suggest to use 
psprintf(). As for checking any hard limit, I don't think it would have 
much value - somehow we got the original command line, thus it is 
supported by the system, so we can just pass it on.

-- Ph.



pgsql-hackers by date:

Previous
From: Ranier Vilela
Date:
Subject: Re: [PATCH] pg_ctl should not truncate command lines at 1024 characters
Next
From: Tom Lane
Date:
Subject: Re: dup(0) fails on Ubuntu 20.04 and macOS 10.15 with 13.0